ClojureScript

Add multi-arg versions of conj! disj! assoc! and dissoc!

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code

Description

The transient collection manipulation functions conj! disj! assoc! and dissoc! don't have an "& rest" argument form, so it is not possible to write for example (conj! t-vec :a :b).

Besides being inconvenient, this is also different from Clojure.

Patch attached.

  1. bench-cljs-734.txt
    04/Jan/14 2:02 AM
    2 kB
    Francis Avila
  2. benchmark_runner.cljs
    04/Jan/14 2:02 AM
    3 kB
    Francis Avila
  3. bench-master.txt
    04/Jan/14 2:02 AM
    2 kB
    Francis Avila
  4. bench-variadic.txt
    04/Jan/14 2:02 AM
    2 kB
    Francis Avila
  5. cljs-734-2.patch
    04/Jan/14 2:02 AM
    2 kB
    Francis Avila

Activity

Francis Avila made changes -
Field Original Value New Value
Attachment cljs-734.patch [ 12563 ]
Francis Avila made changes -
Attachment benchmark_runner.cljs [ 12592 ]
Attachment bench-master.txt [ 12591 ]
Attachment bench-cljs-734.txt [ 12590 ]
Attachment bench-variadic.txt [ 12589 ]
Attachment cljs-734-2.patch [ 12588 ]
David Nolen made changes -
Attachment cljs-734.patch [ 12563 ]
David Nolen made changes -
Attachment multi-arity-transient-fns.patch [ 12562 ]
David Nolen made changes -
Resolution Completed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
David Nolen made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: