ClojureScript

repl/evaluate-form should pass along file-information

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code and Test

Description

I was getting missing file info for core defs in a repl context, where normally (a full compile) would show the correct information.

This is required for repl-level file-metadata, which cider needs for jump-to-definition.
https://github.com/clojure-emacs/cider/issues/462

With the current patch, cider can jump through cljs files and jar resources correctly.

Activity

Hide
Gary Trakhman added a comment -

The relevant line is '(binding [ana/*cljs-file* filename]'.

It sets the var so code down the line can pick it up.

Show
Gary Trakhman added a comment - The relevant line is '(binding [ana/*cljs-file* filename]'. It sets the var so code down the line can pick it up.
Hide
David Nolen added a comment -

Because of whitespace changes it's impossible to see what changed. Can you explain the changes? Thanks!

Show
David Nolen added a comment - Because of whitespace changes it's impossible to see what changed. Can you explain the changes? Thanks!
Hide
Gary Trakhman added a comment -

Further testing shows that file+line is indeed making it through, I think the current patch is enough.

Show
Gary Trakhman added a comment - Further testing shows that file+line is indeed making it through, I think the current patch is enough.
Hide
Gary Trakhman added a comment - - edited

In piggieback, load-stream seems to miss file/line for transitive requires, but it looks fine when I try to replicate it in a cljs test. Will work on it.

Show
Gary Trakhman added a comment - - edited In piggieback, load-stream seems to miss file/line for transitive requires, but it looks fine when I try to replicate it in a cljs test. Will work on it.
Hide
Gary Trakhman added a comment -

fix and repl-based test

Show
Gary Trakhman added a comment - fix and repl-based test

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: