ClojureScript

• Type: Defect
• Status: Closed
• Priority: Major
• Resolution: Completed
• Affects Version/s: None
• Fix Version/s: None
• Component/s: None
• Labels:

  None
• Environment:

  r2156

PersistentVector and Subvec implement their IVector protocol (-assoc-n) with IAssociative (-assoc); it should be the other way around:

1. Because IVector has an additional numeric index contract that IAssociative does not. The neglected number check causes (assoc [0] nil 1) to return [1] instead of throwing an exception.
2. Because Java Clojure does not do this (APersistentVector.assoc does a numeric check then calls PersistentVector.assocN).

See comments in CLJS-728 for more detailed rationales.

Patch attached which reverses this, and also fixes the error when a non-number is used as a key/index to assoc on PersistentVector and Subvec. Note: (assoc! (transient [0]) nil) is still broken.

1. 

   cljs-767.patch

   17/Feb/14 9:58 AM

   3 kB

   Francis Avila

• Assignee:

  Unassigned

  Reporter:

  Francis Avila

• Created:

  17/Feb/14 9:38 AM

  Updated:

  20/Feb/14 11:40 AM

  Resolved:

  20/Feb/14 11:40 AM