Details
-
Type:
Defect
-
Status:
Closed
-
Priority:
Major
-
Resolution: Completed
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
Description
In cljs.reader, the parse-int calls js/parseInt without a radix.
The radix is implementation defined if not specified.
This causes problems for example in older Android browsers which parse "08" as 0 instead of 8.
This makes reading timestamps fail. For example:
Trying to read: #inst "2013-07-08T21:00:00.000-00:00"
causes:
Error: timestamp day field must be in range 1..last day in month Failed: 1<=0<=31
in js console:
parseInt("08") => 0
parseInt("08", 10) => 8
Discovered integer-with-radix parsing problem but split it into
CLJS-775since it's not a simple parseInt issue.This patch should fix ratio and inst parsing, but I don't have access to a browser which infers octals in parseInt.
Existing tests are sufficient to catch this problem for #inst.
There are no ratio tests for reader at all currently, but since ratios are shaky ground in cljs anyway I didn't add any.
CLJS-775since it's not a simple parseInt issue. This patch should fix ratio and inst parsing, but I don't have access to a browser which infers octals in parseInt. Existing tests are sufficient to catch this problem for #inst. There are no ratio tests for reader at all currently, but since ratios are shaky ground in cljs anyway I didn't add any.