ClojureScript

• Type: Defect
• Status: Closed
• Priority: Major
• Resolution: Completed
• Affects Version/s: 0.0-3115
• Fix Version/s: 0.0-3196
• Component/s: None
• Labels:

  None
• Environment:

  clojurescript 0.0-r2227
  target: node

When compiling for node.js, `find-classpath-lib` generates a warning because `cljs/nodejs.js` doesn't contain a `goog.provide` declaration. However, this warning ends up being emitted into the JS files being generated (caused by a call to `with-out-str`), later causing a critical failure in the Closure compiler.

To reproduce:

• `lein new cljs-node buggy`
• Update clojurescript to r2227, lein-cljsbuild to 1.0.3
• `lein cljsbuild once`

Result:

• Multiple warnings
• Generated "buggy.js" file contains only node.js shebang

Fix:

• The simplest patch (attached) is to rebind `out` to `err` when emitting a warning
• A better fix would be to write a function for error printing that wraps this idiom
• Ideally, cljs/nodejs.js should have a `goog.provides` line added to prevent the warning in the first place

1. 

   warn-with-out-str-fix.patch

   02/Jun/14 6:35 AM

   0.8 kB

   Joshua Ballanco

• Assignee:

  Unassigned

  Reporter:

  Joshua Ballanco

• Created:

  02/Jun/14 6:35 AM

  Updated:

  27/Mar/15 7:42 AM

  Resolved:

  27/Mar/15 7:42 AM