ClojureScript

Extending EventType to js/Element breaks Nashorn

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Environment:
    Nashorn

Description

js/Element is undefined in Nashorn (and I would assume other browserless environments)

https://github.com/clojure/clojurescript/blob/master/src/cljs/clojure/browser/event.cljs#L33

  1. cljs_831.patch
    11/Aug/14 11:15 AM
    1 kB
    Dylan Butman
  2. cljs_831.patch
    03/Aug/14 5:30 PM
    1 kB
    Dylan Butman

Activity

Hide
David Nolen added a comment -

can we rebase this patch on master?

Show
David Nolen added a comment - can we rebase this patch on master?
Hide
Dylan Butman added a comment -

yea shouldn't be a problem. Is that something I can/should do?

Show
Dylan Butman added a comment - yea shouldn't be a problem. Is that something I can/should do?
Hide
David Nolen added a comment -

Yes create a new patch rebased on master. Thanks!

Show
David Nolen added a comment - Yes create a new patch rebased on master. Thanks!
Hide
Dylan Butman added a comment -

attached the new patch

Show
Dylan Butman added a comment - attached the new patch

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: