Clojure-Contrib

Implementation-specific logging functions are using reflection

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

As reported by Richard Newman via email.

The lack of type hinting results in multiple reflective calls even if the logging level is disabled. Not fast.

Activity

Hide
Assembla Importer added a comment -

ataggart said: [file:aoZzXWGI0r3PQKeJe5afGb]: Patch to stop reflection

Show
Assembla Importer added a comment - ataggart said: [file:aoZzXWGI0r3PQKeJe5afGb]: Patch to stop reflection
Hide
Assembla Importer added a comment -

ataggart said: Implementation-specific functions no longer need reflection. Now the only reflection warnings remaining are a result of the proxy methods for the log-stream (flush and reset), which I can't figure out how to solve.

Show
Assembla Importer added a comment - ataggart said: Implementation-specific functions no longer need reflection. Now the only reflection warnings remaining are a result of the proxy methods for the log-stream (flush and reset), which I can't figure out how to solve.
Hide
Assembla Importer added a comment -

tomfaulhaber said: (In revision:6dd2205627cd524894b1175da20ce9c5ac65aef7) Added type hints to remove reflection when implementation-specific functions are invoked.
Fixes #10

Branch: master

Show
Assembla Importer added a comment - tomfaulhaber said: (In revision:6dd2205627cd524894b1175da20ce9c5ac65aef7) Added type hints to remove reflection when implementation-specific functions are invoked. Fixes #10 Branch: master

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: