Clojure-Contrib

Converted from http://www.assembla.com/spaces/clojure/tickets/22
Attachments:
ticket-22.patch - https://www.assembla.com/spaces/clojure/documents/aQpl6KQH8r3Q2KeJe5afGb/download/aQpl6KQH8r3Q2KeJe5afGb
0001-Automatically-locate-namespaces-to-AOT-compile.patch - https://www.assembla.com/spaces/clojure/documents/c5gnW-QIqr3RD1eJe5afGb/download/c5gnW-QIqr3RD1eJe5afGb
0001-Ticket-22-patch.patch - https://www.assembla.com/spaces/clojure/documents/dAQ4d0QIKr3O-6eJe5afGb/download/dAQ4d0QIKr3O-6eJe5afGb
0002-Reconcile-the-patch-s-copy-of-build.xml-fixing-XML-f.patch - https://www.assembla.com/spaces/clojure/documents/dAVwG8QIKr3O-6eJe5afGb/download/dAVwG8QIKr3O-6eJe5afGb

hlship said: The patch addresses a number of compilation problems, and fixes things so that a number of tests that were present (but not run) are now run.

I think this is just a starting point, and we need seperate folders to identify main source code, gen classes, and tests so that we don't need so many exclude rules when identifying the namespaces to AOT compile.

hlship said: I'm tyring to use the Eclipse Clojure plugin, but due to this bug, clojure.contrib.repl_ln is not pre-compiled and so it doesn't work. Please take a few minutes to apply the patch!

richhickey said: what patch?

hlship said: That's odd ... what did happen to the patch?

I'll regenerate it, but this is very, very odd. I remember adding it to this ticket (maybe I accidentally added it to a different ticket?).

hlship said: [file:aQpl6KQH8r3Q2KeJe5afGb]: Patch file

hlship said: The patch automatically AOT compiles the code; it automatically locates namespaces to compile. I also located a number of "dead" tests (tests that were not being run), some of which needed to be corrected for the move of c.c.test-is to c.test.

richhickey said: Patches must be prepared with git format-patch:

http://clojure.org/patches

Also, your patch seems to contain many + lines that look to me identical to the lines they replace, which makes it very difficult to see what is new. Any idea why that is happening?

hlship said: [file:c5gnW-QIqr3RD1eJe5afGb]: patch via git format-patch

hlship said: I've create the correct patch ... again, sorry for that. I was rushing.

I'm not sure if that's a spaces vs. tabs issue, or a windows/mac line endings issue.

hlship said: I'm redoing the patch, unstaging the whitespace differences inside build.xml. I'll have it ready in a few minutes.

hlship said: The XML editor I was using put a space before /> in empty tags, thus the changes. Ugh.

hlship said: [file:dAQ4d0QIKr3O-6eJe5afGb]: Revised patch, part 1/2

hlship said: [file:dAVwG8QIKr3O-6eJe5afGb]: Revised patch, part 2/2

hlship said: Just added two new patch files that were created against the latest pull from GitHub master, and do not have the erroneous lines (an XML formatting issue). Should be much more straight forward to apply. Sorry for the trouble.

stu said: looking at this now...

stu said: (In revision:04a22729691863a5b7e7b1b3c6c1157a02aff3b2) compile str-utils2 and other build fixes, refs #22

Branch: master

stu said: pushed to master (04a22729691863a5b7e7b1b3c6c1157a02aff3b2). Let me know if you see any issues.