Clojure-Contrib

Purge removed libraries from load_all.clj

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

(load "clojure/contrib/load_all") has not worked since the penultimate commit to clojure-contrib, as libraries are being moved to core. all-contrib-libs needs to be adjusted to match the new set of libraries.

Activity

Hide
Assembla Importer added a comment -

hircus said: [file:c6XnLWzMGr3QkbeJe5aVNr]: git-generated diff to load_all.clj

Show
Assembla Importer added a comment - hircus said: [file:c6XnLWzMGr3QkbeJe5aVNr]: git-generated diff to load_all.clj
Hide
Assembla Importer added a comment -

scgilardi said: If it's feasible, it would be good to add load-all to the tests that are run by "ant test" so it gets run frequently. (I run ant test every time I build clojure and contrib.)

Show
Assembla Importer added a comment - scgilardi said: If it's feasible, it would be good to add load-all to the tests that are run by "ant test" so it gets run frequently. (I run ant test every time I build clojure and contrib.)
Hide
Assembla Importer added a comment -

scgilardi said: In case somebody likes this idea gets to this before I do: I think it would be cool for load-all to figure out what all the clojure-contrib libraries are on its own: perhaps by searching in the resources in the clojure-contrib Jar file for ns declarations that are exactly "clojure.contrib.[^.]+$" (only one component after clojure.contrib).

We could then maintain a list in the load-all vicinity of only those libraries that should not be loaded by load-all. That seems much easier to maintain as we'll automatically be prompted (by a failure to load) if we forget an exclusion.

Show
Assembla Importer added a comment - scgilardi said: In case somebody likes this idea gets to this before I do: I think it would be cool for load-all to figure out what all the clojure-contrib libraries are on its own: perhaps by searching in the resources in the clojure-contrib Jar file for ns declarations that are exactly "clojure.contrib.[^.]+$" (only one component after clojure.contrib). We could then maintain a list in the load-all vicinity of only those libraries that should not be loaded by load-all. That seems much easier to maintain as we'll automatically be prompted (by a failure to load) if we forget an exclusion.
Hide
Assembla Importer added a comment -

stuart.sierra said: Updating tickets (#1, #2, #3, #4, #6, #20, #23, #25, #30, #31, #33, #34, #35, #37, #38, #52, #55, #58, #59, #60, #61, #62, #63, #64)

Show
Assembla Importer added a comment - stuart.sierra said: Updating tickets (#1, #2, #3, #4, #6, #20, #23, #25, #30, #31, #33, #34, #35, #37, #38, #52, #55, #58, #59, #60, #61, #62, #63, #64)
Hide
Assembla Importer added a comment -

stu said: Here's the approach I took:

  • moved the file from main to test
  • used find-namespace to find all the namespaces
  • removed the deprecated ones
  • manufactured one unit test per namespace that tries to load the namespace
Show
Assembla Importer added a comment - stu said: Here's the approach I took:
  • moved the file from main to test
  • used find-namespace to find all the namespaces
  • removed the deprecated ones
  • manufactured one unit test per namespace that tries to load the namespace

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: