Clojure-Contrib

Replace instances of ^ reader macro with (meta ...)

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

Clojure 1.1 is deprecating the form ^x in favor of (meta x) in order to reclaim the ^ prefix.

We need to get clojure.contrib to respect this in order to avoid having deprecation warnings.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Assembla Importer added a comment -

abscondment said: [file:dmYXqQ5Iyr3QaYeJe5afGb]: I believe this replaces all instances of the macro.

Show
Assembla Importer added a comment - abscondment said: [file:dmYXqQ5Iyr3QaYeJe5afGb]: I believe this replaces all instances of the macro.
Hide
Permalink
Assembla Importer added a comment -

tomfaulhaber said: (In revision:e5b7819ef66410a87b8072417dc2f09ac4ddb03f) Changed all instances of ^x across contrib to (meta x) since the ^x form is being deprecated in 1.1
refs #48

Branch: master

Show
Assembla Importer added a comment - tomfaulhaber said: (In revision:e5b7819ef66410a87b8072417dc2f09ac4ddb03f) Changed all instances of ^x across contrib to (meta x) since the ^x form is being deprecated in 1.1 refs #48 Branch: master
Hide
Permalink
Assembla Importer added a comment -

tomfaulhaber said: Sorry, Brendan I didn't see your patch before I did almost exactly the same thing. I went ahead and pushed my stuff instead since I don't think that yours would have passed test_contrib (the pprint test you modified would have failed in your version, I just took it out in my version). Let me know if I missed anything.

Show
Assembla Importer added a comment - tomfaulhaber said: Sorry, Brendan I didn't see your patch before I did almost exactly the same thing. I went ahead and pushed my stuff instead since I don't think that yours would have passed test_contrib (the pprint test you modified would have failed in your version, I just took it out in my version). Let me know if I missed anything.
Hide
Permalink
Assembla Importer added a comment -

abscondment said: Oh, no worries! The tests passed when I ran them (unless I've gone totally crazy), but I don't think coverage is really worse off without that one.

Show
Assembla Importer added a comment - abscondment said: Oh, no worries! The tests passed when I ran them (unless I've gone totally crazy), but I don't think coverage is really worse off without that one.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4#649-r158309) | Report a problem
Powered by a free Atlassian JIRA open source license for Clojure. Try JIRA - bug tracking software for your team.