Clojure-Contrib

fix pprint tests and reenable

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

Apparently (according to ticket 65), someone has broken the pprint tests, presumably during the switch to maven and all the hacking to get around gen-class/maven bugs.

Take a look at this and fix it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Assembla Importer added a comment -

Converted from http://www.assembla.com/spaces/clojure/tickets/66

Show
Assembla Importer added a comment - Converted from http://www.assembla.com/spaces/clojure/tickets/66
Hide
Permalink
Assembla Importer added a comment -

stuart.sierra said: It appears that the ColumnWriter/-init function is getting called with 3 arguments.

Show
Assembla Importer added a comment - stuart.sierra said: It appears that the ColumnWriter/-init function is getting called with 3 arguments.
Hide
Permalink
Assembla Importer added a comment -

stuart.sierra said: I don't think this was caused by changes in the build. Something has changed about how arguments get passed to init functions. The ColumnWriter init function is getting the same arguments as the PrettyWriter init function (a Writer, 72, and 40).

Show
Assembla Importer added a comment - stuart.sierra said: I don't think this was caused by changes in the build. Something has changed about how arguments get passed to init functions. The ColumnWriter init function is getting the same arguments as the PrettyWriter init function (a Writer, 72, and 40).
Hide
Permalink
Assembla Importer added a comment -

stuart.sierra said: (In revision:5b3beaed9ef8520c8c1e09ff7ac5b817786f51e2) Fix mis-named ns in pprint.gen-class; refs #66

Branch: master

Show
Assembla Importer added a comment - stuart.sierra said: (In revision:5b3beaed9ef8520c8c1e09ff7ac5b817786f51e2) Fix mis-named ns in pprint.gen-class; refs #66 Branch: master
Hide
Permalink
Assembla Importer added a comment -

stuart.sierra said: Never mind, it was a simple typo in the gen_class.clj file. Nothing to do with pprint or with the build process.

Tests re-enabled; all pass.

Show
Assembla Importer added a comment - stuart.sierra said: Never mind, it was a simple typo in the gen_class.clj file. Nothing to do with pprint or with the build process. Tests re-enabled; all pass.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4#649-r158309) | Report a problem
Powered by a free Atlassian JIRA open source license for Clojure. Try JIRA - bug tracking software for your team.