core.rrb-vector

Check whether Iterator implementation correctly implements next by throwing required NoSuchElementException

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

Note: There might not be any bug in core.rrb-vector's implementation of Iterator methods. I have not checked the details yet. Just creating reminder tickets to check if there is an issue in core.rrb-vector similar to CLJ-1453 in Clojure. Please close as declined with a comment if everything is already implemented correctly here, or it is not applicable for some reason.

Activity

Hide
Michał Marczyk added a comment -

Thanks for the ticket!

There was one implementation throwing the expected NoSuchElementException and three others throwing IndexOutOfBoundsException.

This is now fixed on master:

Test https://github.com/clojure/core.rrb-vector/commit/c45bcf8b06f88bbcac7f9b2bf0ccc20db0b327c6
Fix https://github.com/clojure/core.rrb-vector/commit/faf55bacb8fc0ab798256a975d2b8847d501a993
Show
Michał Marczyk added a comment - Thanks for the ticket! There was one implementation throwing the expected NoSuchElementException and three others throwing IndexOutOfBoundsException. This is now fixed on master:
Test https://github.com/clojure/core.rrb-vector/commit/c45bcf8b06f88bbcac7f9b2bf0ccc20db0b327c6
Fix https://github.com/clojure/core.rrb-vector/commit/faf55bacb8fc0ab798256a975d2b8847d501a993

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: