core.typed

core library annotation

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code

Description

add some core library annotation to get familiar with the whole process of development

Activity

Hide
Ambrose Bonnaire-Sergeant added a comment -

You can use macros to generate var annotations; see how clojure.core/count does it.

Read only Agents should be: (Agent2 Nothing Any).

Show
Ambrose Bonnaire-Sergeant added a comment - You can use macros to generate var annotations; see how clojure.core/count does it. Read only Agents should be: (Agent2 Nothing Any).
Hide
Di Xu added a comment -

Then, what should await1 be annotated? [(Agent2 Nothing Any) -> (Agent2 Nothing Any)]? But result type should be writable.

Show
Di Xu added a comment - Then, what should await1 be annotated? [(Agent2 Nothing Any) -> (Agent2 Nothing Any)]? But result type should be writable.
Di Xu made changes -
Field Original Value New Value
Attachment annotation.diff [ 12860 ]
Di Xu made changes -
Attachment annotation-v2.diff [ 12861 ]
Hide
Ambrose Bonnaire-Sergeant added a comment -

Is await1 even a public function? Weird, it has no docstring.

I think it should be:

(All [w r] [(Agent2 w r) -> (Agent2 w r)])

Show
Ambrose Bonnaire-Sergeant added a comment - Is await1 even a public function? Weird, it has no docstring. I think it should be: (All [w r] [(Agent2 w r) -> (Agent2 w r)])
Hide
Di Xu added a comment -

Ah, I forget about polymorphic function, sorry.

Show
Di Xu added a comment - Ah, I forget about polymorphic function, sorry.
Di Xu made changes -
Attachment annotation-v2.diff [ 12861 ]
Di Xu made changes -
Attachment annotation-v3.diff [ 12863 ]
Ambrose Bonnaire-Sergeant made changes -
Resolution Completed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Ambrose Bonnaire-Sergeant made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: