core.typed

namespace check-ns-common has unnecessary dependency on itself

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

Discovered while attempting to run Eastwood on unmodified core.typed

Activity

Hide
Andy Fingerhut added a comment -

Patch fix.patch removes the unnecessary and unused :require line. Its presence causes tools.namespace and tools based on them, e.g. Eastwood, to throw an exception due to a circular dependency.

Show
Andy Fingerhut added a comment - Patch fix.patch removes the unnecessary and unused :require line. Its presence causes tools.namespace and tools based on them, e.g. Eastwood, to throw an exception due to a circular dependency.
Andy Fingerhut made changes -
Field Original Value New Value
Attachment fix.patch [ 13060 ]
Hide
Ambrose Bonnaire-Sergeant added a comment -

Thanks, and apologies to Eastwood! Merged.

Show
Ambrose Bonnaire-Sergeant added a comment - Thanks, and apologies to Eastwood! Merged.
Ambrose Bonnaire-Sergeant made changes -
Resolution Completed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Ambrose Bonnaire-Sergeant made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Hide
Andy Fingerhut added a comment -

Thanks for the change, but there is no need to apologies to Eastwood It still has rough edges all over the place where code that the Clojure compiler handles causes Eastwood to throw exceptions for various reasons, and not all of them are because the Clojure compiler is lenient.

Show
Andy Fingerhut added a comment - Thanks for the change, but there is no need to apologies to Eastwood It still has rough edges all over the place where code that the Clojure compiler handles causes Eastwood to throw exceptions for various reasons, and not all of them are because the Clojure compiler is lenient.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: