core.typed

A few more issues discovered via linting

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

I can include a patch if you want, but given that you may want to make some but not all of these changes, I will just describe them for now.

src/main/clojure/clojure/core/typed.clj has two nearly identical occurrences of function reset-cache. One returns nil explicitly, the other does not. Best to have only one implementation.

src/main/clojure/clojure/core/typed/check.clj has an expression (assoc-in [:types kt] vt) that appears to be the wrong number of args for assoc-in. I am not sure what is intended there.

src/main/clojure/clojure/core/typed/errors.clj has two def's for int-error-kw. One would be better.

src/main/clojure/clojure/core/typed/subtype.clj has an expression (and (r/HSet? s)) that could be replaced with (r/HSet? s)

Activity

Ambrose Bonnaire-Sergeant made changes -
Field Original Value New Value
Resolution Completed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Ambrose Bonnaire-Sergeant made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: