core.typed

Bogus deprecation messages from core.typed

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: 0.2.0
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

"DEPRECATED SYNTAX (client/reactive.clj): Any syntax is deprecated, use clojure.core.typed/Any" - Um, sure?

Activity

Hide
Ambrose Bonnaire-Sergeant added a comment -

There are quite a few of these messages I need to stamp out. What version are you on, and does any particular code trigger it?

Show
Ambrose Bonnaire-Sergeant added a comment - There are quite a few of these messages I need to stamp out. What version are you on, and does any particular code trigger it?
Hide
Daniel Ziltener added a comment -

I'm on version 0.2.51. There are other such messages, especially core.typed itself triggers a lot of "U syntax is deprecated, use clojure.core.typed/U" messages.

Show
Daniel Ziltener added a comment - I'm on version 0.2.51. There are other such messages, especially core.typed itself triggers a lot of "U syntax is deprecated, use clojure.core.typed/U" messages.
Hide
Sean Corfield added a comment -

Repro for 0.2.52:

  • lein new app typed-test
  • edit project.clj and add [org.clojure/core.typed "0.2.52"] as a dependency and {{:plugins [[lein-typed "0.3.4"]]}}
  • edit src/typed_test/core.clj and add {{(:require [clojure.core.typed])}}
  • run lein typed check typed-test.core

You get this output:

DEPRECATED SYNTAX (typed_test/core.clj): Any syntax is deprecated, use clojure.core.typed/Any

This comes from parse-unparse/parse-type-symbol 'Any but I haven't been able to figure out what triggers it yet. It's clearly not triggered by anything in user code tho' since it happens even when user code does not mention Any.

Show
Sean Corfield added a comment - Repro for 0.2.52:
  • lein new app typed-test
  • edit project.clj and add [org.clojure/core.typed "0.2.52"] as a dependency and {{:plugins [[lein-typed "0.3.4"]]}}
  • edit src/typed_test/core.clj and add {{(:require [clojure.core.typed])}}
  • run lein typed check typed-test.core
You get this output: DEPRECATED SYNTAX (typed_test/core.clj): Any syntax is deprecated, use clojure.core.typed/Any This comes from parse-unparse/parse-type-symbol 'Any but I haven't been able to figure out what triggers it yet. It's clearly not triggered by anything in user code tho' since it happens even when user code does not mention Any.
Hide
Sean Corfield added a comment -

Found it: line 58 of analyze_clj.clj uses ~'Any but it should use T/Any.

I made that one change locally and installed 0.2.53-SNAPSHOT and the warning goes away for my test case when I depend on the snapshot.

Show
Sean Corfield added a comment - Found it: line 58 of analyze_clj.clj uses ~'Any but it should use T/Any. I made that one change locally and installed 0.2.53-SNAPSHOT and the warning goes away for my test case when I depend on the snapshot.
Hide
Ambrose Bonnaire-Sergeant added a comment -

I believe I stamped out all of these bogus messages in 0.2.53. Please let me know.

Show
Ambrose Bonnaire-Sergeant added a comment - I believe I stamped out all of these bogus messages in 0.2.53. Please let me know.
Hide
Sean Corfield added a comment -

I no longer see any deprecation warnings with 0.2.53 against our codebase. Thank you!

Show
Sean Corfield added a comment - I no longer see any deprecation warnings with 0.2.53 against our codebase. Thank you!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: