core.typed

Eliminate the need to specify all ancestors in alter-class.

Details

  • Type: Task Task
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: Backlog
  • Component/s: Clojure Checker
  • Labels:

Description

We should be able to elide at least a couple of these annotations.

PersistentHashSet [[[a :variance :covariant]]
                   :replace
                   {Seqable (Seqable a)
                    java.util.Set (java.util.Set a)
                    Iterable (Iterable a)
                    Collection (Collection a)
                    APersistentSet (APersistentSet a)
                    IPersistentSet (IPersistentSet a)
                    IPersistentCollection (IPersistentCollection a)}
                   :unchecked-ancestors
                   #{[Any -> (U a nil)]}]

I think just override APersistentSet should infer the rest.

PersistentHashSet [[[a :variance :covariant]]
                   :replace
                   {APersistentSet (APersistentSet a)}
                   :unchecked-ancestors
                   #{[Any -> (U a nil)]}]

:unchecked-ancestors is a different problem.

Activity

Ambrose Bonnaire-Sergeant made changes -
Field Original Value New Value
Status Open [ 1 ] In Progress [ 3 ]
Ambrose Bonnaire-Sergeant made changes -
Status In Progress [ 3 ] Open [ 1 ]
Ambrose Bonnaire-Sergeant made changes -
Description We should be able to elide at least a couple of these annotations.

{code}
PersistentHashSet [[[a :variance :covariant]]
                   :replace
                   {Seqable (Seqable a)
                    java.util.Set (java.util.Set a)
                    Iterable (Iterable a)
                    Collection (Collection a)
                    APersistentSet (APersistentSet a)
                    IPersistentSet (IPersistentSet a)
                    IPersistentCollection (IPersistentCollection a)}
                   :unchecked-ancestors
                   #{[Any -> (U a nil)]}]
{code}

I think just override APersistentSet should infer the rest.

:unchecked-ancestors is a different problem.
Ambrose Bonnaire-Sergeant made changes -
Description We should be able to elide at least a couple of these annotations.

{code}
PersistentHashSet [[[a :variance :covariant]]
                   :replace
                   {Seqable (Seqable a)
                    java.util.Set (java.util.Set a)
                    Iterable (Iterable a)
                    Collection (Collection a)
                    APersistentSet (APersistentSet a)
                    IPersistentSet (IPersistentSet a)
                    IPersistentCollection (IPersistentCollection a)}
                   :unchecked-ancestors
                   #{[Any -> (U a nil)]}]
{code}

I think just override APersistentSet should infer the rest.

:unchecked-ancestors is a different problem.
We should be able to elide at least a couple of these annotations.

{code}
PersistentHashSet [[[a :variance :covariant]]
                   :replace
                   {Seqable (Seqable a)
                    java.util.Set (java.util.Set a)
                    Iterable (Iterable a)
                    Collection (Collection a)
                    APersistentSet (APersistentSet a)
                    IPersistentSet (IPersistentSet a)
                    IPersistentCollection (IPersistentCollection a)}
                   :unchecked-ancestors
                   #{[Any -> (U a nil)]}]
{code}

I think just override APersistentSet should infer the rest.

{code}
PersistentHashSet [[[a :variance :covariant]]
                   :replace
                   {APersistentSet (APersistentSet a)}
                   :unchecked-ancestors
                   #{[Any -> (U a nil)]}]
{code}


:unchecked-ancestors is a different problem.
Ambrose Bonnaire-Sergeant made changes -
Fix Version/s 0.2.0 [ 10158 ]
Fix Version/s 0.4 [ 10550 ]
Ambrose Bonnaire-Sergeant made changes -
Fix Version/s Release 0.4 [ 10550 ]
Fix Version/s Backlog [ 10554 ]
Ambrose Bonnaire-Sergeant made changes -
Component/s Clojure Checker [ 10007 ]
Ambrose Bonnaire-Sergeant made changes -
Labels newbie

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated: