core.typed

A few annotations were added for clojure.string namespace.

Details

  • Type: Enhancement Enhancement
  • Status: Resolved Resolved
  • Priority: Trivial Trivial
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code and Test

Description

Typed annotations were added for blank?,capitalize,lower-case,replace,reverse and trim.

  1. string_updated.diff
    24/Jul/14 9:32 AM
    2 kB
    Aravind K N
  2. string.diff
    18/Jul/14 8:06 AM
    1 kB
    Aravind K N

Activity

Hide
Andy Fingerhut added a comment -

Aravind, triml and trimr have the same type as trim, and should be easy to add.

clojure.string/replace has a more complex type than [String -> String]. Take a look at the documentation string to get a better idea of what it does. clojure.string/replace-first has the same type signature, so once you get one right you can copy it to the other.

Show
Andy Fingerhut added a comment - Aravind, triml and trimr have the same type as trim, and should be easy to add. clojure.string/replace has a more complex type than [String -> String]. Take a look at the documentation string to get a better idea of what it does. clojure.string/replace-first has the same type signature, so once you get one right you can copy it to the other.
Hide
Aravind K N added a comment -

Added annotations for replace-first, triml,trimr and altered the annotation for replace.

Show
Aravind K N added a comment - Added annotations for replace-first, triml,trimr and altered the annotation for replace.
Hide
Aravind K N added a comment -

This is cleared.
Could someone change it to fixed?

Show
Aravind K N added a comment - This is cleared. Could someone change it to fixed?
Hide
Ambrose Bonnaire-Sergeant added a comment -

Merged, thanks all!

Show
Ambrose Bonnaire-Sergeant added a comment - Merged, thanks all!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: