core.typed

GSOC 2014 Heterogeneous operations & Dotted Polymorphism

Details

  • Type: Enhancement Enhancement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

interface changed:

syntax:

  • add `:repeat true` to HSeq, HVec and HSequential
  • add `<*` and `<...` to Function

type:

  • Function (add prest, pdot)
  • Hsequential (add repeat attribute)
  • HSeq (add repeat attribute)
  • HVec (add repeat attribute)
  • AssocType (add dentries support)

internal function:

  • make-Function (use keyword argument instead of position argument)
  • check-fn-method1-rest-type in check.clj (add prest, pdot keyword argument)
  • merge function of parse/unparse, frees, fold, substitute-dots, substitute-dotted for HSeq, HVec and HSequential to use one function.

check result:

  • apply hash-map will now returns Map instead of HMap

docs:

  • add tutorial on inference to docs directory

built-in function annotation changed/added:

  • hash-map
  • apply
  • assoc
  • keep-indexed

Activity

Hide
Ambrose Bonnaire-Sergeant added a comment -

I tried applying and got this error.

ambrose@ambrose-VirtualBox:~/Projects/core.typed-branches/di$ git am --keep-cr -s --ignore-whitespace < patch.diff
Applying: add :repeat field to HeterogeneousVector HeterogeneousSeq and HSequential
error: src/main/clojure/clojure/core/typed/type_rep.clj: does not exist in index
Patch failed at 0001 add :repeat field to HeterogeneousVector HeterogeneousSeq and HSequential
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".

Most of the src/main files are now in module-check/src/main.

Show
Ambrose Bonnaire-Sergeant added a comment - I tried applying and got this error.
ambrose@ambrose-VirtualBox:~/Projects/core.typed-branches/di$ git am --keep-cr -s --ignore-whitespace < patch.diff
Applying: add :repeat field to HeterogeneousVector HeterogeneousSeq and HSequential
error: src/main/clojure/clojure/core/typed/type_rep.clj: does not exist in index
Patch failed at 0001 add :repeat field to HeterogeneousVector HeterogeneousSeq and HSequential
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
Most of the src/main files are now in module-check/src/main.
Hide
Ambrose Bonnaire-Sergeant added a comment -

Just looked at your branch, not really sure where this is going wrong.

Show
Ambrose Bonnaire-Sergeant added a comment - Just looked at your branch, not really sure where this is going wrong.
Hide
Di Xu added a comment -

well, I'm using

git format-patch master --stdout > patch.diff

to format patch, what should I use?

Show
Di Xu added a comment - well, I'm using
git format-patch master --stdout > patch.diff
to format patch, what should I use?
Hide
Ambrose Bonnaire-Sergeant added a comment -

Yea that's what I would use... I don't know enough git.

Show
Ambrose Bonnaire-Sergeant added a comment - Yea that's what I would use... I don't know enough git.
Hide
Di Xu added a comment -

it seems [patch is not able to do this kind of work](https://stackoverflow.com/questions/2285699/git-how-to-create-patches-for-a-merge) because I merge master once in the middle of my commit sequence.

I also failed to rebase it, because you change source dir, rebase failed on my first commit.

I'm not sure how to solve it now..

Show
Di Xu added a comment - it seems [patch is not able to do this kind of work](https://stackoverflow.com/questions/2285699/git-how-to-create-patches-for-a-merge) because I merge master once in the middle of my commit sequence. I also failed to rebase it, because you change source dir, rebase failed on my first commit. I'm not sure how to solve it now..
Hide
Ambrose Bonnaire-Sergeant added a comment -

I'll just pull from your Github branch at this point.

You've included all the changes in your patch.

Show
Ambrose Bonnaire-Sergeant added a comment - I'll just pull from your Github branch at this point. You've included all the changes in your patch.
Hide
Di Xu added a comment -

ok, then.

Show
Di Xu added a comment - ok, then.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated: