data.finger-tree

x should be x# in definition of equiv method inside defdigit?

Details

  • Type: Defect Defect
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

In this sequence of lines in defdigit:

IPersistentCollection
        (empty [_]) ; TBD ; not needed?
        (equiv [_ x] false) ; TBD
        (cons [_ x#] (digit ~'meter-obj ~@items x#))

it appears like the equiv method should have x# instead of x.

I would not have noticed this, except I have been trying out tools.analyzer and tools.analyzer.jvm on the contrib libraries, and it threw an exception when analyzing method equiv because the defdigit macro expanded into a deftype that had a namespace on the parameter x.

Activity

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: