data.xml

Some unit tests are never run because their names are the same

Details

  • Type: Defect Defect
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

Whenever two deftest statements have the same name, the first is ignored and its tests are never run.

In namespace clojure.data.xml.test-emit, there are two deftests with name defaults, and two with the name test-indent.

Found using pre-release version of Eastwood Clojure lint tool.

Activity

Hide
Ryan Senior added a comment -

Patch applied

Show
Ryan Senior added a comment - Patch applied
Hide
Andy Fingerhut added a comment -

Patch dxml-21-v1.diff makes all deftest names unique. I have not attempted to correct any new failing tests, if any.

Show
Andy Fingerhut added a comment - Patch dxml-21-v1.diff makes all deftest names unique. I have not attempted to correct any new failing tests, if any.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: