Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Clean up syntax for create table DDL to improve options handling

Description

Version 0.5.5 introduced a single options map, flagged by the :options argument. This is a compromise while I figure out the better way to change create-table-ddl to be a better behaved function, instead of being inherently variadic.

Environment

None

Activity

Show:

Sean Corfield April 10, 2016 at 3:12 AM

This has been implemented ready for 0.5.6.

Sean Corfield April 9, 2016 at 11:03 PM

Since the arguments are really:

  • table name

  • list of column specs

  • options

It probably makes sense to have the signature:

so it takes either three or four arguments: a name (string / symbol / keyword), a collection of column specs (require the column specs to be vectors), an optional map of options.

Given that the current form is variadic but the "middle" arguments are not maps anyway, introducing :options in 0.5.5 was unnecessary, but consistent with the changes for insert!.

Version 0.5.6 should support both forms, then 0.6.0 can drop support for the general variadic version.

Completed

Details

Assignee

Reporter

Priority

Created April 9, 2016 at 10:57 PM
Updated June 1, 2016 at 6:41 PM
Resolved June 1, 2016 at 6:41 PM