[#JDBC-17] Type-hint public fns returning Connection - Clojure JIRA

clojure.java.jdbc/connection and find-connection both return a java.sql.Connection but are not type-hinted.

There is a type hint on clojure.java.jdbc.internal/connection*, but it does not carry through to the public Var.

Tagging these functions eliminates 9 reflection warnings in a project I have.

Ascending order - Click to sort in descending order

Field	Original Value	New Value
Description	{{{clojure.java.jdbc/connection}}} and {{{find-connection}}} both return a {{{java.sql.Connection}}} but are not type-hinted. There is a type hint on {{{clojure.java.jdbc.internal/connection*}}}, but it does not carry through to the public Var. Tagging these functions eliminates 9 reflection warnings in a project I have.	{{clojure.java.jdbc/connection}} and {{find-connection}} both return a {{java.sql.Connection}} but are not type-hinted. There is a type hint on {{clojure.java.jdbc.internal/connection*}}, but it does not carry through to the public Var. Tagging these functions eliminates 9 reflection warnings in a project I have.

Attachment

JDBC-17-a.patch [ 10378 ]

Patch

Code

Hide

Permalink

Sean Corfield added a comment - 10/Oct/11 11:21 PM

Patch applied. Thanx Stuart!

Show

Sean Corfield added a comment - 10/Oct/11 11:21 PM Patch applied. Thanx Stuart!

Sean Corfield made changes - 10/Oct/11 11:21 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Completed [ 1 ]

Vote (0)

Watch (0)