[#JDBC-24] Make where-params optional for update-values function - Clojure JIRA

Details

Type: Enhancement
Status: Resolved
Priority: Minor
Resolution: Declined
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
None

Patch:
Code and Test

Description

This prevents having to pass a wonky always-true clause (e.g. ["1=1"]) as the where-params when updating all the rows in a table.

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

optional-where-params-update-values.patch

04/Jan/12 11:03 PM

3 kB

Trent Ogren

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Trent Ogren added a comment - 04/Jan/12 11:04 PM

I'm aware that I might have to sign the Clojure CA. I just thought I'd see what you think first...

Show

Trent Ogren added a comment - 04/Jan/12 11:04 PM I'm aware that I might have to sign the Clojure CA. I just thought I'd see what you think first...

Hide

Permalink

Sean Corfield added a comment - 04/Jan/12 11:43 PM

See ~~JDBC-14~~ since I'm declining this for the same reason. Performing a global update is an unusual operation and I think the API should prevent you from accidentally updating all rows, just as it should prevent you from deleting all rows. Requiring a where clause does that.

Show

Sean Corfield added a comment - 04/Jan/12 11:43 PM See ~~JDBC-14~~ since I'm declining this for the same reason. Performing a global update is an unusual operation and I think the API should prevent you from accidentally updating all rows, just as it should prevent you from deleting all rows. Requiring a where clause does that.

People

Assignee:

Sean Corfield

Reporter:

Trent Ogren

Vote (0)

Watch (0)

Dates

Created:

04/Jan/12 11:03 PM

Updated:

04/Jan/12 11:43 PM

Resolved:

04/Jan/12 11:43 PM

java.jdbc

Make where-params optional for update-values function