java.jdbc

• Type: Defect
• Status: Resolved
• Priority: Major
• Resolution: Declined
• Affects Version/s: None
• Fix Version/s: None
• Component/s: None
• Labels:

  None
• Environment:

  Hide

  Ubuntu
  OpenJDK:
  java version "1.6.0_22"
  OpenJDK Runtime Environment (IcedTea6 1.10.6) (6b22-1.10.6-0ubuntu1)
  OpenJDK 64-Bit Server VM (build 20.0-b11, mixed mode)
  
  OS X Java
  java version "1.6.0_29"
  Java(TM) SE Runtime Environment (build 1.6.0_29-b11-402-10M3527)
  Java HotSpot(TM) 64-Bit Server VM (build 20.4-b02-402, mixed mode)
  
  Relevant clojure libraries
    [org.clojure/clojure "1.3.0"]
    [korma "0.3.0-beta9"]
    [org.clojure/java.jdbc "0.1.3"]
    [postgresql/postgresql "9.1-901.jdbc3"]
  

  Show

  Ubuntu OpenJDK: java version "1.6.0_22" OpenJDK Runtime Environment (IcedTea6 1.10.6) (6b22-1.10.6-0ubuntu1) OpenJDK 64-Bit Server VM (build 20.0-b11, mixed mode) OS X Java java version "1.6.0_29" Java(TM) SE Runtime Environment (build 1.6.0_29-b11-402-10M3527) Java HotSpot(TM) 64-Bit Server VM (build 20.4-b02-402, mixed mode) Relevant clojure libraries   [org.clojure/clojure "1.3.0"]   [korma "0.3.0-beta9"]   [org.clojure/java.jdbc "0.1.3"]   [postgresql/postgresql "9.1-901.jdbc3"]

I'm using the Clojure library Korma to generate SQL for Postgres, which depends on clojure.java.jdbc. Recently I added a custom 'upsert' query. Using it on normal java 1.6 is fine, but on openJDK it breaks due to the use of 'java.sql.Statement/RETURN_GENERATED_KEYS'. This makes the Postgres driver add a seemingly random "RETURNING *" at the end of the query.

On normal Java 1.6 java.sql.Statement/RETURN_GENERATED_KEYS doesn't exist and then a exception is caught and everything works as expected. Sounds like the world up side down, but I'm probably missing the rational behind this.

The line that causes the weird behavior is here: https://github.com/clojure/java.jdbc/blob/master/src/main/clojure/clojure/java/jdbc/internal.clj#L315

The code that showcases the 'bug' is here:
https://gist.github.com/2e8a3d55d80707ce79e0

(Sorry for the monkey patching in the gist, if there is a better way I would love to hear it)

I guess a naive patch would be to remove the java.sql.Statement/RETURN_GENERATED_KEYS line, but there must be a reason for its existence I assume.

• Assignee:

  Sean Corfield

  Reporter:

  Jeroen van Dijk

• Created:

  30/Mar/12 3:20 AM

  Updated:

  31/Mar/12 1:30 AM

  Resolved:

  31/Mar/12 1:30 AM