java.jdbc

• Type: Defect
• Status: Resolved
• Priority: Major
• Resolution: Completed
• Affects Version/s: None
• Fix Version/s: None
• Component/s: None
• Labels:

  • patch,
  • performance

HSQLDB returns an empty ResultSet when using (.getGeneratedKeys stmt)
and no keys are generated. So this Exception is thrown for each record
without generated keys.

While this Exception is caught in do-prepared-return-keys, this can lead to a huge overhead caused by the JVM exception handling. I did a performance test.

Before Patch:

clojure.java.test-jdbc> (time (sql/with-connection hsqldb-db (count (apply sql/insert-records :dummy  (map #(hash-map :name (str %) :id %) (range 10000))))))
"Elapsed time: 3429.346743 msecs"
10000

After Patch:

 clojure.java.test-jdbc> (time (sql/with-connection hsqldb-db (count (apply sql/insert-records :dummy  (map #(hash-map :name (str %) :id %) (range 10000))))))
"Elapsed time: 1397.444753 msecs"

1. 

   0001-add-make-cols-unique-test-case-empty-cols.patch

   12/May/12 11:51 AM

   0.9 kB

   Jürgen Hötzel

2. 

   0002-distinct-throws-clojure.lang.ArityException-when-app.patch

   12/May/12 11:51 AM

   2 kB

   Jürgen Hötzel

• Assignee:

  Sean Corfield

  Reporter:

  Jürgen Hötzel

• Created:

  12/May/12 11:51 AM

  Updated:

  10/Jun/12 5:24 PM

  Resolved:

  10/Jun/12 5:24 PM