java.jdbc

Permit non-keyword labels

Details

  • Type: Enhancement Enhancement
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Declined
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

This line of code in jdbc.clj:

(map (comp keyword identifiers)))

... made sense before the newish as-arrays? feature. The results were always maps, and with maps it is idiomatic to use keywords as keys.

But when returning the results as nested lists, the first entry contains the field identifiers; these might very reasonably be something other than keywords.

I suggest that when the user passes in their own function to translate from fields to keys, that the user be able to make them keys whatever they like, perhaps plain strings or perhaps somethings else.

As a workaround, of one can just let this code keywordize the information, then unkeywordize it outside afterward.

Activity

Hide
Sean Corfield added a comment -

Given the workaround is easy - and the behavior to-date is well-known and well-documented - I'm not going to complicate the machinery to support non-keywords in array results here.

Show
Sean Corfield added a comment - Given the workaround is easy - and the behavior to-date is well-known and well-documented - I'm not going to complicate the machinery to support non-keywords in array results here.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: