java.jdbc

Review (and fix) reflection warnings

Details

  • Type: Task Task
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

There are quite a few reflection warnings in the c.j.j code which should be reviewed and performance critical pieces type hinted.

Activity

Hide
Allen Rohner added a comment -

Empirically, I can tell you the one in do-prepared*, (.prepareStatement (connection), and the one in transaction* (let [con (connection*) ...) are both performance critical for me.

Show
Allen Rohner added a comment - Empirically, I can tell you the one in do-prepared*, (.prepareStatement (connection), and the one in transaction* (let [con (connection*) ...) are both performance critical for me.
Hide
Sean Corfield added a comment -

Thanx Allen. The impression I get from clojure-dev is new contrib libraries should have zero reflection warnings so I plan to find and fix all such cases in c.j.j.

Show
Sean Corfield added a comment - Thanx Allen. The impression I get from clojure-dev is new contrib libraries should have zero reflection warnings so I plan to find and fix all such cases in c.j.j.
Hide
Sean Corfield added a comment -

All reflection warnings have been removed.

Show
Sean Corfield added a comment - All reflection warnings have been removed.
Sean Corfield made changes -
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Completed [ 1 ]

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: