[#LOGIC-63] Prep's use of metadata needs to be extended to other objects in ClojureScript - Clojure JIRA

Details

Type: Defect
Status: Resolved
Priority: Major
Resolution: Completed
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
None

Description

The simple unifier and binding-map work great in the simple cases, but fail with more complicated unification.
The root cause is prep's use of metadata banging up against JS Objects.

For the cases that fail, see the current failing tests:
https://github.com/clojure/core.logic/blob/master/src/test/cljs/cljs/core/logic/tests.cljs#L871

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

David Nolen added a comment - 26/Oct/12 12:42 PM - edited

I still don't understand. Is it failing because it's trying to add metadata to objects which don't support that? That doesn't really make sense given the unifications that are failing that you've highlighted.

Show

David Nolen added a comment - 26/Oct/12 12:42 PM - edited I still don't understand. Is it failing because it's trying to add metadata to objects which don't support that? That doesn't really make sense given the unifications that are failing that you've highlighted.

Hide

Permalink

Paul deGrandis added a comment - 26/Oct/12 12:55 PM

That's correct - I couldn't determine what the Object was in the code. Whatever it is, it just needs the IWithMeta protocol extended to it.

I thought you might have more insight.

Show

Paul deGrandis added a comment - 26/Oct/12 12:55 PM That's correct - I couldn't determine what the Object was in the code. Whatever it is, it just needs the IWithMeta protocol extended to it. I thought you might have more insight.

Hide

Permalink

David Nolen added a comment - 26/Oct/12 12:58 PM

Ok will look into it.

Show

David Nolen added a comment - 26/Oct/12 12:58 PM Ok will look into it.

David Nolen made changes - 26/Oct/12 5:51 PM

Field	Original Value	New Value
Status	Open [ 1 ]	In Progress [ 3 ]

Hide

Permalink

David Nolen added a comment - 26/Oct/12 5:53 PM

fixed http://github.com/clojure/core.logic/commit/371c0355f51ee35c6e71616ec2923a8242d6e4b3

Show

David Nolen added a comment - 26/Oct/12 5:53 PM fixed http://github.com/clojure/core.logic/commit/371c0355f51ee35c6e71616ec2923a8242d6e4b3

David Nolen made changes - 26/Oct/12 5:53 PM

Resolution		Completed [ 1 ]
Status	In Progress [ 3 ]	Resolved [ 5 ]

People

Assignee:

David Nolen

Reporter:

Paul deGrandis

Vote (0)

Watch (1)

Dates

Created:

26/Oct/12 12:34 PM

Updated:

26/Oct/12 5:53 PM

Resolved:

26/Oct/12 5:53 PM