[#LOGIC-77] Finite-domain vars inside a vector crash when constrained. - Clojure JIRA

Details

Type: Defect
Status: Resolved
Priority: Major
Resolution: Completed
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
None
Environment:
clojure 1.5.0-beta1 with core.logic 0.8.0-beta3

Description

I don't know a lot about the finite domain code, but it surprised me that this crashes:

(run 1 [r a b x]
  (== r [a b])
  (infd a b x (domain 1 2))
  (<fd a b)
  (firsto r x))

This was the most minimal example I could come up with.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

David Nolen added a comment - 15/Dec/12 7:43 PM

This commit http://github.com/clojure/core.logic/commit/07f2f6ac42ad13ed7476f70669b98e76a84f2455 fixes the exception. However I'm still not seeing the expected result which I believe is:

([[1 2] 1 2 1])

Show

David Nolen added a comment - 15/Dec/12 7:43 PM This commit http://github.com/clojure/core.logic/commit/07f2f6ac42ad13ed7476f70669b98e76a84f2455 fixes the exception. However I'm still not seeing the expected result which I believe is:

([[1 2] 1 2 1])

Hide

Permalink

David Nolen added a comment - 15/Dec/12 9:17 PM

This is bug results from the trickiness of aliasing of logic vars in the presence of constraints. Currently when two constrained vars are unified, we point one var to the other var and migrate the constraints. However this is not enough we also need to merge their domains - this is not currently being done.

Show

David Nolen added a comment - 15/Dec/12 9:17 PM This is bug results from the trickiness of aliasing of logic vars in the presence of constraints. Currently when two constrained vars are unified, we point one var to the other var and migrate the constraints. However this is not enough we also need to merge their domains - this is not currently being done.

David Nolen made changes - 15/Dec/12 10:15 PM

Field	Original Value	New Value
Status	Open [ 1 ]	In Progress [ 3 ]

Hide

Permalink

David Nolen added a comment - 24/Dec/12 6:14 PM

fixed, http://github.com/clojure/core.logic/commit/d4d4cd53edfd76c2f416bd699f4b4d914f880985

Show

David Nolen added a comment - 24/Dec/12 6:14 PM fixed, http://github.com/clojure/core.logic/commit/d4d4cd53edfd76c2f416bd699f4b4d914f880985

David Nolen made changes - 24/Dec/12 6:14 PM

Resolution		Completed [ 1 ]
Status	In Progress [ 3 ]	Resolved [ 5 ]

People

Assignee:

David Nolen

Reporter:

Gary Fredericks

Vote (0)

Watch (1)

Dates

Created:

15/Dec/12 4:12 PM

Updated:

24/Dec/12 6:14 PM

Resolved:

24/Dec/12 6:14 PM