core.match

Setting *warn-on-reflection* affects all code using core.match

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

Setting warn-on-reflection affects all use of core.match.

Please remove all cases where warn-on-reflection is set.

This can be set by the pom for the project, rather than in source, so it doesn't affect code using core.match.

Activity

Hide
Hugo Duncan added a comment -

Thanks!

I assume the clojure build is using clojure-maven-plugin, in which case it is just a matter of setting warnOnReflection. Something like this (untested):

<build>
 <plugins>
  <plugin>
    <groupId>com.theoryinpractise</groupId>
    <artifactId>clojure-maven-plugin</artifactId>
    <configuration>
      <warnOnReflection>true</warnOnReflection>
    </configuration>
  </plugin>
 </plugins>
</build>
Show
Hugo Duncan added a comment - Thanks! I assume the clojure build is using clojure-maven-plugin, in which case it is just a matter of setting warnOnReflection. Something like this (untested):
<build>
 <plugins>
  <plugin>
    <groupId>com.theoryinpractise</groupId>
    <artifactId>clojure-maven-plugin</artifactId>
    <configuration>
      <warnOnReflection>true</warnOnReflection>
    </configuration>
  </plugin>
 </plugins>
</build>
Hide
David Nolen added a comment -

Fixed, https://github.com/clojure/core.match/commit/f75152edb697cff9bbe9070478b5bc0105f140ca

Do you have an example of setting it in the POM?

Show
David Nolen added a comment - Fixed, https://github.com/clojure/core.match/commit/f75152edb697cff9bbe9070478b5bc0105f140ca Do you have an example of setting it in the POM?

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: