[#MATCH-24] Setting *warn-on-reflection* affects all code using core.match - Clojure JIRA

Details

Type: Defect
Status: Resolved
Priority: Major
Resolution: Completed
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
None

Description

Setting warn-on-reflection affects all use of core.match.

Please remove all cases where warn-on-reflection is set.

This can be set by the pom for the project, rather than in source, so it doesn't affect code using core.match.

Activity

Descending order - Click to sort in ascending order

Hide

Permalink

Hugo Duncan added a comment - 03/Oct/11 11:32 AM

Thanks!

I assume the clojure build is using clojure-maven-plugin, in which case it is just a matter of setting warnOnReflection. Something like this (untested):

<build>
 <plugins>
  <plugin>
    <groupId>com.theoryinpractise</groupId>
    <artifactId>clojure-maven-plugin</artifactId>
    <configuration>
      <warnOnReflection>true</warnOnReflection>
    </configuration>
  </plugin>
 </plugins>
</build>

Show

Hugo Duncan added a comment - 03/Oct/11 11:32 AM Thanks! I assume the clojure build is using clojure-maven-plugin, in which case it is just a matter of setting warnOnReflection. Something like this (untested):

<build>
 <plugins>
  <plugin>
    <groupId>com.theoryinpractise</groupId>
    <artifactId>clojure-maven-plugin</artifactId>
    <configuration>
      <warnOnReflection>true</warnOnReflection>
    </configuration>
  </plugin>
 </plugins>
</build>

Hide

Permalink

David Nolen added a comment - 03/Oct/11 7:38 AM

Fixed, https://github.com/clojure/core.match/commit/f75152edb697cff9bbe9070478b5bc0105f140ca

Do you have an example of setting it in the POM?

Show

David Nolen added a comment - 03/Oct/11 7:38 AM Fixed, https://github.com/clojure/core.match/commit/f75152edb697cff9bbe9070478b5bc0105f140ca Do you have an example of setting it in the POM?

People

Assignee:

David Nolen

Reporter:

Hugo Duncan

Vote (0)

Watch (0)

Dates

Created:

03/Oct/11 7:29 AM

Updated:

03/Oct/11 11:32 AM

Resolved:

03/Oct/11 7:38 AM