core.match

Matching maps with :only broken in CLJS

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code

Description

The `.keySet` method call doesn't exist on JavaScript objects.
Master throws compile errors on me, so I've attached a patch against alpha9 that removes the Java method call in favor of the pure Clojure `(set (keys m))`

  1. cljs_keyset.patch
    30/Jun/12 11:34 AM
    1 kB
    Kevin Lynagh
  2. cljs_keyset.patch
    18/Jun/12 10:19 AM
    1 kB
    Kevin Lynagh

Activity

Hide
Kevin Lynagh added a comment - - edited

Updated patch against master that uses clojurescript var. Also available at https://github.com/lynaghk/core.match/tree/60-cljs-keyset

Show
Kevin Lynagh added a comment - - edited Updated patch against master that uses clojurescript var. Also available at https://github.com/lynaghk/core.match/tree/60-cljs-keyset
Hide
David Nolen added a comment - - edited

It would preferable to check the *clojurescript* dynamic var and do different emission. Thanks!

Show
David Nolen added a comment - - edited It would preferable to check the *clojurescript* dynamic var and do different emission. Thanks!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: