[#MATCH-60] Matching maps with :only broken in CLJS - Clojure JIRA

Details

Type: Defect
Status: Resolved
Priority: Minor
Resolution: Completed
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
None

Patch:
Code

Description

The `.keySet` method call doesn't exist on JavaScript objects.
Master throws compile errors on me, so I've attached a patch against alpha9 that removes the Java method call in favor of the pure Clojure `(set (keys m))`

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

cljs_keyset.patch

18/Jun/12 10:19 AM

1 kB

Kevin Lynagh
cljs_keyset.patch

30/Jun/12 11:34 AM

1 kB

Kevin Lynagh

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

David Nolen added a comment - 18/Jun/12 10:49 AM - edited

It would preferable to check the *clojurescript* dynamic var and do different emission. Thanks!

Show

David Nolen added a comment - 18/Jun/12 10:49 AM - edited It would preferable to check the *clojurescript* dynamic var and do different emission. Thanks!

Hide

Permalink

Kevin Lynagh added a comment - 30/Jun/12 11:34 AM - edited

Updated patch against master that uses clojurescript var. Also available at https://github.com/lynaghk/core.match/tree/60-cljs-keyset

Show

Kevin Lynagh added a comment - 30/Jun/12 11:34 AM - edited Updated patch against master that uses clojurescript var. Also available at https://github.com/lynaghk/core.match/tree/60-cljs-keyset

Hide

Permalink

David Nolen added a comment - 01/Jul/12 11:03 AM

fixed, http://github.com/clojure/core.match/commit/cdeea55f211f1dbe4768c8aec3149bfcb00438a2

Show

David Nolen added a comment - 01/Jul/12 11:03 AM fixed, http://github.com/clojure/core.match/commit/cdeea55f211f1dbe4768c8aec3149bfcb00438a2

People

Assignee:

David Nolen

Reporter:

Kevin Lynagh

Vote (0)

Watch (0)

Dates

Created:

18/Jun/12 10:19 AM

Updated:

01/Jul/12 11:03 AM

Resolved:

01/Jul/12 11:03 AM