tools.nrepl

:session key is overloaded

Details

  • Type: Defect Defect
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

The session middleware takes the :session key from the message, and uses it as an id to lookup session data, which it then places on the same key.

Using a separate key for the session id and the session data would be less confusing, and would allow easier checking of the availability of the session data in the message map.

Activity

Hide
Chas Emerick added a comment -

The session id will need to continue to come in in the :session slot, as I don't want to break clients (and, there's very, very few middlewares out there yet).

Suggestions for names for the actual session atom? :the-session? :-/

Show
Chas Emerick added a comment - The session id will need to continue to come in in the :session slot, as I don't want to break clients (and, there's very, very few middlewares out there yet). Suggestions for names for the actual session atom? :the-session? :-/
Chas Emerick made changes -
Field Original Value New Value
Fix Version/s 0.2.0-beta9 [ 10151 ]
Chas Emerick made changes -
Fix Version/s 0.2.0-beta9 [ 10151 ]
Fix Version/s 0.2.0-beta10 [ 10153 ]
Chas Emerick made changes -
Fix Version/s 0.2.0-beta10 [ 10153 ]

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated: