tools.nrepl

Improve Java version information

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: 0.2.4
  • Fix Version/s: 0.2.5
  • Component/s: None
  • Labels:
  • Patch:
    Code and Test

Description

As discussed before - structure the Java version information similarly to nREPL and Clojure's.

Activity

Hide
Chas Emerick added a comment -

My original hesitation was largely due to a suspicion that JVM version strings are not particularly regular, especially across vendors. Perhaps that simple regex will work on all Sun/Oracle VM's, but let's keep things clean in any cases where it won't: if no match is found, let's not include the major/minor/etc slots with nil values.

Show
Chas Emerick added a comment - My original hesitation was largely due to a suspicion that JVM version strings are not particularly regular, especially across vendors. Perhaps that simple regex will work on all Sun/Oracle VM's, but let's keep things clean in any cases where it won't: if no match is found, let's not include the major/minor/etc slots with nil values.
Hide
Bozhidar Batsov added a comment -

See the updated patch - if we don't find 4 numbers in the version string we don't include any extra slots.

Show
Bozhidar Batsov added a comment - See the updated patch - if we don't find 4 numbers in the version string we don't include any extra slots.
Hide
Chas Emerick added a comment -

Thanks, applied. Looks like there's often no update version included, so I tweaked things so that 3-4 slots are acceptable. e.g. http://build.clojure.org/job/tools.nrepl-test-matrix/163/CLOJURE_VERSION=1.3.0,jdk=Oracle%20JDK%201.7/console (search for java.version).

Show
Chas Emerick added a comment - Thanks, applied. Looks like there's often no update version included, so I tweaked things so that 3-4 slots are acceptable. e.g. http://build.clojure.org/job/tools.nrepl-test-matrix/163/CLOJURE_VERSION=1.3.0,jdk=Oracle%20JDK%201.7/console (search for java.version).
Hide
Bozhidar Batsov added a comment -

Yeah, turns out the first build doesn't have an update. Thanks!

Show
Bozhidar Batsov added a comment - Yeah, turns out the first build doesn't have an update. Thanks!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: