tools.analyzer

adds end-line and end-column information to source-info

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code and Test

Description

goal particularly is to use this info in clj-refactor but this additional info can be useful for other code analyzer and/or munging libraries.

currently we are experimenting to turn clj-refactor into a nrepl middleware based, editor agnostic clojure refactor tool, see cider-and-ast branch. for this we use tools.analyzer and work on the AST. the feature we use in the experiment intends to remove debug functions like println, prn etc. in order to easily integrate with our client which is emacs-lisp code for now we need end-line information, please see this and this snippets particularly.

Activity

Hide
Nicola Mometto added a comment -

I'll be more than happy to take this patch, can you please attach patch created with git format-patch?
Also since this is a contrib library you need to sign the elettronic Clojure CA, https://secure.echosign.com/public/hostedForm?formid=95YMDL576B336E
Thanks

Show
Nicola Mometto added a comment - I'll be more than happy to take this patch, can you please attach patch created with git format-patch? Also since this is a contrib library you need to sign the elettronic Clojure CA, https://secure.echosign.com/public/hostedForm?formid=95YMDL576B336E Thanks
Hide
Benedek Fazekas added a comment -

hi,

I just signed electronic Clojure CA 30 mins ago. Let me sort out the format patch thing too...

Show
Benedek Fazekas added a comment - hi, I just signed electronic Clojure CA 30 mins ago. Let me sort out the format patch thing too...
Hide
Benedek Fazekas added a comment -

hope this suffices

Show
Benedek Fazekas added a comment - hope this suffices
Hide
Nicola Mometto added a comment -

Ok, it's going to take a couple of days until your name appears in the contributors list (http://clojure.org/contributing) once it's there I'll merge this.
I was planning on releasing a new version of ta/taj today, I'll wait a couple of extra days to get this included.

Thanks again

Show
Nicola Mometto added a comment - Ok, it's going to take a couple of days until your name appears in the contributors list (http://clojure.org/contributing) once it's there I'll merge this. I was planning on releasing a new version of ta/taj today, I'll wait a couple of extra days to get this included. Thanks again
Hide
Benedek Fazekas added a comment -

sounds great, thx!

Show
Benedek Fazekas added a comment - sounds great, thx!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: