test.check

Move rose-tree code into a separate namespace.

Details

  • Type: Enhancement Enhancement
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

The rose tree code is logically separate from the rest of the generator code, and is already pseudo-namespaced by the inclusion of the word "rose" in the function names.

Activity

Hide
Gary Fredericks added a comment -

Attached a patch that moves the rose-tree functions into their own namespace, and removes "rose" from the function names.

The latter part is a bit trickier, and a couple times involved naming collisions for t he names root and children which are now functions in the rose-tree namespace but are also often locals in that namespaces as well. I twice changed the locals to the-root or the-namespace to resolve the collision.

Show
Gary Fredericks added a comment - Attached a patch that moves the rose-tree functions into their own namespace, and removes "rose" from the function names. The latter part is a bit trickier, and a couple times involved naming collisions for t he names root and children which are now functions in the rose-tree namespace but are also often locals in that namespaces as well. I twice changed the locals to the-root or the-namespace to resolve the collision.
Hide
Reid Draper added a comment -

Merged in 9cc5cac08a9dc5ec0d327e12c502dea1f7741958. Thanks!

Show
Reid Draper added a comment - Merged in 9cc5cac08a9dc5ec0d327e12c502dea1f7741958. Thanks!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: