test.check

Improve symbol and keyword generators

Details

  • Type: Enhancement Enhancement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Patch:
    Code

Description

Create a generator for symbols.

Also modify the keyword generator to allow :'s (as per the spec) (http://clojure.org/reader)

Create generators for namespaced symbols and keywords, as these were not tested before.

The new generators are added to gen/any.

A patch (namespaced-symbols-2014-07-11-14-38.diff) is attached.

Also a suggestion (but not in the patch): the edn-roundtrips test should be run separately on each type in gen/any to adequately search the space for errors.

Activity

Hide
Reid Draper added a comment -

Aside from +or--digit?, are all of the rest of the definitions in this patch intended to be public? It's a little unclear to me which of these are public generators and which are just helpers.

Show
Reid Draper added a comment - Aside from +or--digit?, are all of the rest of the definitions in this patch intended to be public? It's a little unclear to me which of these are public generators and which are just helpers.
Hide
Eric Normand added a comment - - edited

This patch is the same as the previous one with the non-interface functions set as private.

Patch: namespaced-symbols-2014-07-23.diff

Show
Eric Normand added a comment - - edited This patch is the same as the previous one with the non-interface functions set as private. Patch: namespaced-symbols-2014-07-23.diff
Hide
Reid Draper added a comment -

Thanks! Merged in bc1650d4136d3453a6c16a363c1d5db36ad9a6b1.

Show
Reid Draper added a comment - Thanks! Merged in bc1650d4136d3453a6c16a363c1d5db36ad9a6b1.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: