[#TCLI-1] Do not include keys when no value provided and no :default - Clojure JIRA

Details

Type: Enhancement
Status: Closed
Priority: Minor
Resolution: Completed
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
None

Patch:
Code and Test

Description

I was trying to use tools.cli in conjunction with a configuration map
loaded from a file, and use clojure.core/merge to combine the results.

This didn't work because tools.cli always uses a default value of
nil, even when no default value is specified. The nil always
overrides defaults from another source.

Example before the patch:

(def my-defaults
  {:foo 1})

(merge my-defaults
       (first (clojure.tools.cli/cli
               [] ; no arguments given
               ["--foo"]))) ; no default specified
;;=> {:foo nil}

This enhancement modifies tools.cli to completely omit arguments which
have no default specified and no value given on the command line.

After the patch, the above example returns:

;;=> {:foo 1}

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

TCLI-1-0001.patch

18/May/12 3:37 PM

2 kB

Stuart Sierra
TCLI-1-0002.patch

20/Jul/12 7:41 AM

2 kB

Stuart Sierra

Activity

Ascending order - Click to sort in descending order

Stuart Sierra made changes - 18/May/12 3:37 PM

Field	Original Value	New Value
Patch		Code and Test [ 10002 ]
Waiting On		gar3thjon3s
Attachment		TCLI-1-0001.patch [ 11229 ]

Hide

Permalink

Stuart Sierra added a comment - 20/Jul/12 7:41 AM

New patch file 0002 fixes syntax error in the previous patch; updated description to show correct results.

Show

Stuart Sierra added a comment - 20/Jul/12 7:41 AM New patch file 0002 fixes syntax error in the previous patch; updated description to show correct results.

Stuart Sierra made changes - 20/Jul/12 7:41 AM

Description	I was trying to use tools.cli in conjunction with a configuration map loaded from a file, and use clojure.core/merge to combine the results. This didn't work because tools.cli always uses a default value of {{nil}}, even when no default value is specified. The {{nil}} always overrides defaults from another source. Example before the patch: {code} (def my-defaults {:foo 1}) (merge my-defaults (first (clojure.tools.cli/cli [] ; no arguments given ["--foo"]))) ; no default specified ;;=> {:foo nil} {code} This enhancement modifies tools.cli to completely omit arguments which have no default specified and no value given on the command line. After the patch, the above example returns: {code} ;;=> {:foo nil} {code}	I was trying to use tools.cli in conjunction with a configuration map loaded from a file, and use clojure.core/merge to combine the results. This didn't work because tools.cli always uses a default value of {{nil}}, even when no default value is specified. The {{nil}} always overrides defaults from another source. Example before the patch: {code} (def my-defaults {:foo 1}) (merge my-defaults (first (clojure.tools.cli/cli [] ; no arguments given ["--foo"]))) ; no default specified ;;=> {:foo nil} {code} This enhancement modifies tools.cli to completely omit arguments which have no default specified and no value given on the command line. After the patch, the above example returns: {code} ;;=> {:foo 1} {code}
Attachment		TCLI-1-0002.patch [ 11390 ]