tools.cli

Correct test that trivially always passes

Details

  • Type: Defect Defect
  • Status: Resolved Resolved
  • Priority: Trivial Trivial
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

The following tools.cli test always trivially passes, because (= expr) is always true:

(is (= {:verbose false}))

Found using pre-release version of Eastwood Clojure lint tool.

Activity

Andy Fingerhut made changes -
Field Original Value New Value
Description The following tools.cli test always trivially passes, because (= expr) is always true:
{code}
        (is (= {:verbose false}))
{code}
The following tools.cli test always trivially passes, because (= expr) is always true:
{code}
        (is (= {:verbose false}))
{code}
Found using pre-release version of Eastwood Clojure lint tool.
Hide
Andy Fingerhut added a comment -

Patch tcli-8-v1.diff corrects the test.

Show
Andy Fingerhut added a comment - Patch tcli-8-v1.diff corrects the test.
Andy Fingerhut made changes -
Attachment tcli-8-v1.diff [ 12577 ]
Sung Pae made changes -
Assignee Gareth Jones [ gar3thjon3s ] Sung Pae [ guns ]
Hide
Sung Pae added a comment -

Thank you, patch applied!

Show
Sung Pae added a comment - Thank you, patch applied!
Sung Pae made changes -
Resolution Completed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: