tools.logging

• Type: Defect
• Status: Resolved
• Priority: Blocker
• Resolution: Completed
• Affects Version/s: None
• Fix Version/s: None
• Component/s: None
• Labels:

  None

Example of error when trying to call a Logger protocol function:

java.lang.IllegalArgumentException: No implementation of method: :enabled? of protocol:
#'clojure.tools.logging.impl/Logger found for class: org.apache.log4j.Logger

The bug is the result of combining syntax-quoting with extend-type, e.g.:

`(do
   (extend-type org.apache.commons.logging.Log
     Logger
     (enabled? [logger# level#] ... )))

The syntax-quote turns the above enabled? into clojure.tools.logging/enabled? protocol function name, and then the extend-type turns that into the keyword :clojure.tools.logging/enabled?, which does not match the expected :enabled?.

Attached patch fixes this by using extend maps rather than extend-type. Also adds some tests.

1. 

   fix-broken-extend.patch

   29/Sep/11 2:58 PM

   10 kB

   Alexander Taggart

• Assignee:

  Alexander Taggart

  Reporter:

  Alexander Taggart

• Created:

  29/Sep/11 2:58 PM

  Updated:

  29/Sep/11 3:36 PM

  Resolved:

  29/Sep/11 3:36 PM