tools.reader

Add end-line and end-column metadata to read objects

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code and Test

Description

Per TRDR-9, add end-line and end-column metadata information to every form read, when the underlying reader implements the IndexingReader protocol.

Activity

Hide
Alexander Redington added a comment - - edited

Patch to include end-line and end-column numbers on all forms read, with tests.

Show
Alexander Redington added a comment - - edited Patch to include end-line and end-column numbers on all forms read, with tests.
Hide
Nicola Mometto added a comment -

Applied to master: https://github.com/clojure/tools.reader/commit/a7251e87c5530e04c3c7c4a983f30030f38730df

I'm sorry I didn't apply this earlier but JIRA didn't send me an email notifying me that you updated the patch even though I am watching the issue.

Show
Nicola Mometto added a comment - Applied to master: https://github.com/clojure/tools.reader/commit/a7251e87c5530e04c3c7c4a983f30030f38730df I'm sorry I didn't apply this earlier but JIRA didn't send me an email notifying me that you updated the patch even though I am watching the issue.
Hide
Alexander Redington added a comment -

I've only been working on this in Friday time, and even that has been sporadic, so nothing to worry about!

Working with you on this has been excellent, thanks for accepting the suggestions and patches!

Show
Alexander Redington added a comment - I've only been working on this in Friday time, and even that has been sporadic, so nothing to worry about! Working with you on this has been excellent, thanks for accepting the suggestions and patches!

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: