Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

CLJS: syntax-quote doesn't auto-qualify symbols

Description

If x resolves to cljs.user/x then read-string on "`x" should result in the cljs.user namespace being incorporated in the result.

For example, testing using the Node REPL that ships with ClojureScript:

The result should instead be

Environment

None

Attachments

1

Activity

Show:

Nicola Mometto January 4, 2016 at 2:23 PM

Thanks, pushed a fix

Mike Fikes January 4, 2016 at 3:23 AM

The attached unit test causes unit tests to pass.

Additionally, it works properly downstream with the Planck bootstrapped ClojureScript REPL, producing the expected output for the syntax quote examples in Colin Jones's post: https://blog.8thlight.com/colin-jones/2012/05/22/quoting-without-confusion.html

Mike Fikes January 4, 2016 at 3:18 AM

Analysis: resolve-symbol should be called in the syntax-quote* cond branch dealing with symbol?. (just as is done in the CLJ implementation).

Completed

Details

Assignee

Reporter

Patch

Code and Test

Priority

Created January 4, 2016 at 3:15 AM
Updated January 4, 2016 at 2:23 PM
Resolved January 4, 2016 at 2:23 PM