tools.reader

Some uses of reflection in tools.reader code slow it down unnecessarily

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code

Description

Attached patch uses type hints to eliminate several instances of reflection in the tools.reader code.

FYI, you can run 'lein check' to cause Leiningen to compile the code with warn-on-reflection true, I believe for every source file (not sure about the tests, but reflection isn't such a big deal in them anyway).

Activity

Andy Fingerhut made changes -
Field Original Value New Value
Attachment trdr-6-eliminate-reflection-with-type-hints-patch-v1.txt [ 11956 ]
Andy Fingerhut made changes -
Patch Code [ 10001 ]
Nicola Mometto made changes -
Resolution Completed [ 1 ]
Status Open [ 1 ] Closed [ 6 ]

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: