<< Back to previous view

[CCACHE-30] make-reference need not be dynamic Created: 09/Feb/13  Updated: 04/Aug/14  Resolved: 04/Aug/14

Status: Closed
Project: core.cache
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Enhancement Priority: Major
Reporter: Paul Stadig Assignee: Fogus
Resolution: Completed Votes: 0
Labels: None


 Description   

It looks like make-reference was made dynamic to support multiple clojure versions. Rebinding make-reference is really only needed for tests, and it would be a shame if making it dynamic causes performance issues.

Perhaps it is not enough of a performance issue to worry about. Otherwise, it might be possible to work around it. Perhaps directly pasting in and using the with-redefs macro, or something similar?



 Comments   
Comment by Ambrose Bonnaire-Sergeant [ 04/Aug/14 10:46 PM ]

Fixed https://github.com/clojure/core.cache/commit/ce63e6a9cbec64d10c65ffa8d11716c533396094

Generated at Thu Oct 23 03:25:16 CDT 2014 using JIRA 4.4#649-r158309.