<< Back to previous view

[CLJ-1041] reduce-kv on sorted maps should stop on seeing a Reduced value Created: 10/Aug/12  Updated: 18/Aug/12  Resolved: 18/Aug/12

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.5

Type: Defect Priority: Major
Reporter: Alan Malloy Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Attachments: Text File sorted-map-kvreduce.patch    
Patch: Code and Test
Approval: Ok

 Description   

The current implementation is dereferencing Reduced and returning them up the chain; but that means that parent nodes don't know the reduction has completed, so the reduction might continue along other paths down the tree.

This patch touches the same areas of code as CLJ-1040 so will have conflicts if both patches are merged separately. However, as noted in my comment on CLJ-1040, I don't think the patch there is correct yet, so I've also included a commit (7beb14256) to fix the issue in CLJ-1040. Thus, this patch can be merged independently of 1040's patch, solving both issues without a merge conflict.

This patch also includes tests for both issues, which fail before my commits are applied, and pass afterwards.



 Comments   
Comment by Aaron Bedra [ 14/Aug/12 7:46 PM ]

Patch applies cleanly against 4004d267e124f12b65b0d7fb6522f32a75e3c4fb. Submitter confirmed on the CA list.

Generated at Thu Oct 02 07:44:04 CDT 2014 using JIRA 4.4#649-r158309.