[CLJ-1067] Fix error message inconsistencies in Symbol and Keyword Created: 14/Sep/12 Updated: 01/Mar/13 Resolved: 17/Sep/12
1. There are some ugly and unnecessary – but harmless – inconsistencies between Symbol and Keyword:
2. Keyword.java contains a lot of code that has already been factored out to AFn.java.
I propose that Keyword is modified to extend AFn to resolve the above issues.
|Comment by Stuart Halloway [ 17/Sep/12 7:03 AM ]|
At first glance, it appears that there could be some code sharing here. But the attached patch changes the semantics of run, which is a non-starter.
|Comment by Christoffer Sawicki [ 17/Sep/12 7:19 AM ]|
The only thing that changes is the type of thrown exception.
Current call tree:
Keyword.run() -> throw new UnsupportedOperationException()
Call tree with patch applied:
Keyword.run() -> AFn.run() -> AFn.invoke() -> AFn.throwArity(0) -> throw new ArityException(...)
(I.e. Keyword.run() always throws an exception, with and without my patch.)