<< Back to previous view

[CLJ-1091] update changes.md to include 1.5 changes Created: 22/Oct/12  Updated: 11/Dec/12  Resolved: 11/Dec/12

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.5

Type: Task Priority: Major
Reporter: Stuart Halloway Assignee: Timothy Baldridge
Resolution: Completed Votes: 0
Labels: None

Attachments: File changes-draft-v10.md     File changes-draft-v11.md     File changes-draft-v5.md    
Approval: Ok

 Comments   
Comment by Andy Fingerhut [ 15/Nov/12 11:01 AM ]

changes-draft-v1.md is not a patch, but an outline of a proposed new changes.md file for Clojure 1.5 with some of the content fleshed out. It still has lots of occurrences of "TBD" for "To Be Documented" in it.

It does mention every ticket that had a patch committed since Clojure 1.4.0 until Nov 15 2012.

I am hoping someone who is more knowledgeable of the "TBD" parts takes this and runs with it.

Comment by Andy Fingerhut [ 22/Nov/12 7:16 PM ]

changes-draft-v2.md is very similar to the earlier changes-draft-v1.md described above, but has a few additions.

Comment by Timothy Baldridge [ 26/Nov/12 2:41 PM ]

V3 of the draft...should be almost good to go. Someone with more info on reducers should take a look at that section as have yet to actually use them much.

Comment by Andy Fingerhut [ 26/Nov/12 8:47 PM ]

Removed V2 of the draft as Timothy's V3 had all of it and more.

Comment by Timothy Baldridge [ 27/Nov/12 8:52 AM ]

Fleshed out the reducers section a bit.

Comment by Timothy Baldridge [ 27/Nov/12 8:53 AM ]

Alright, I think this is ready for a final review by someone besides me.

Comment by Christopher Redinger [ 28/Nov/12 12:48 PM ]

Editorial cleanup

Comment by Andy Fingerhut [ 28/Nov/12 12:56 PM ]

Christopher, isn't this file intended to be in Markdown format, not HTML?

Comment by Christopher Redinger [ 28/Nov/12 12:58 PM ]

uploading the correct md file

Comment by Andy Fingerhut [ 28/Nov/12 1:12 PM ]

changes-draft-v6.md same as v5, except for a couple of spelling corrections.

Comment by Timothy Baldridge [ 29/Nov/12 8:38 AM ]

Missing desc on when->. Fixed in v7 of the doc

Comment by Rich Hickey [ 02/Dec/12 6:37 PM ]

"1.1 Clojure 1.5 requires Java 1.6 or later"

did you mean "building Clojure 1.5"?

I don't know that anything requires 1.6

Comment by Rich Hickey [ 02/Dec/12 6:41 PM ]

test->, let-> when->

are now:

cond->, as-> and some->

Comment by Andy Fingerhut [ 02/Dec/12 6:49 PM ]

I'll put up an updated version soon, but that headline wasn't properly updated to match the later occurrence of it in the body, which is: "Clojure 1.5 reducers library requires Java 6 or later". Is it true that the ForkJoin library requires Java 6 or later? If not, how can it be made to work with Java 5?

Comment by Andy Fingerhut [ 02/Dec/12 8:42 PM ]

changes-draft-v8.md updates the table of contents headings to match those in the body, and updates names of new threading macros.

Comment by Steve Miner [ 03/Dec/12 9:40 AM ]

changes-draft-v8.md, section 2.4, needs an update for description of some->. The document says "logical true" where it should say "not nil". Same comment applies to some->>. The point is that false will thread through the forms. This is a change from the replaced when-> (in 1.5-beta1).

Comment by Timothy Baldridge [ 03/Dec/12 10:02 AM ]

updated to reflect changes to some-> and some->>

Comment by Steve Miner [ 03/Dec/12 10:15 AM ]

Sorry to nit pick, but there are two more "logical true" phrases in v9 that need to change to "not nil" in those some-> and some->> descriptions.

Comment by Timothy Baldridge [ 03/Dec/12 10:22 AM ]

Not a problem. Thanks for looking it over!

Comment by Stuart Halloway [ 03/Dec/12 1:30 PM ]

I find the following sentence a little vague: "Clojure 1.5 can still be compiled and run with Java 5, but the test suite will not pass due to the lack of support for ForkJoin."

The problem is the application of the "but" to both parts of the conjunction. Isn't the intent actually: "Clojure can run with Java version 1.5 or later. Running the Clojure build requires 1.6, in order to test features that work with ForkJoin."

Comment by Andy Fingerhut [ 03/Dec/12 1:52 PM ]

Stuart H, that is almost the intent, and probably close enough for this kind of documentation.

The full gory details are as follows:

Clojure can build and run with Java version 1.5 or later. A Java version 1.5 build of Clojure only works if you do not run the test suite, e.g. by using the command "ant jar". To build Clojure including running the test suite, or to use the new reducers library, requires Java 1.6 or later.

If the patch for CLJ-1109 is applied, the full gory details become simpler to state:

Clojure can build and run with Java version 1.5 or later. Using the new reducers library requires Java 1.6 or later.

Comment by Andy Fingerhut [ 03/Dec/12 1:59 PM ]

changes-draft-v11.md changes the description of Java 5 limitations to match the current gory details, and hopefully address Stuart H's concerns raised above.

Generated at Sat Sep 20 15:10:44 CDT 2014 using JIRA 4.4#649-r158309.