[CLJ-1151] Minor Code Cleanup in core.reducers: use required walk, drop this for coll Created: 21/Jan/13 Updated: 03/Sep/13
|Affects Version/s:||Release 1.5|
First, core.reducers requires clojure.walk :as walk, but does not use the alias.
The two things seem small enough to be put into one cleanup case.
|Comment by Jozef Wagner [ 03/Sep/13 6:47 AM ]|
your patch is wrong. If you want to replace this with coll, you have to allso call xf on f1.
|Comment by Stefan Kamphausen [ 03/Sep/13 2:45 PM ]|
Scary, that the test suite did not detect that.
|Comment by Andy Fingerhut [ 03/Sep/13 2:59 PM ]|
Is it straightforward to add a test that would have detected that?
|Comment by Stefan Kamphausen [ 03/Sep/13 4:09 PM ]|
I will happily look into that. It may take a few days, before I'll find the time, though.