[CLJ-1254] Incorrect long quot result involving Long/MIN_VALUE Created: 06/Sep/13 Updated: 04/Oct/14
|Affects Version/s:||Release 1.5|
|Patch:||Code and Test|
Similar issue to
Rich Hickey stated in a comment on CLJ-1225 that this case should throw an exception.
Question: For inc (which throws when given input Long/MAX_VALUE) there is an auto-promoting inc' and an unchecked-inc. quot now throws an exception in this case. Should there be an auto-promoting quot' and an unchecked-quot?
|Comment by Andy Fingerhut [ 06/Sep/13 10:55 AM ]|
Patch clj-1254-v1.txt causes (quot Long/MIN_VALUE -1) to throw an exception due to overflow of the result, if the arguments are both long.
Unlike inc, which has auto-promoting version inc' and unchecked version unchecked-inc, there is no auto-promoting quot' and unchecked unchecked-quot. This patch does not add one.
Should quot' and unchecked-quot be added? If so, this ticket or a separate one?
|Comment by Andy Fingerhut [ 23/Nov/13 12:59 AM ]|
Patch clj-1254-2.diff is identical to clj-1254-v1.txt except it applies cleanly to latest master. The only changes were in the context of the lines that were changed, due to a recent commit made.
|Comment by Alex Miller [ 04/Oct/14 10:23 PM ]|
quot should throw an an exception on overflow